On 2016-07-14 20:53:07 -0700, Andres Freund wrote: > On 2016-07-13 23:06:07 -0700, Andres Freund wrote: > > won't enter the branch, because HEAP_XMAX_LOCK_ONLY won't be set. Which > > will leave t_ctid and HEAP_HOT_UPDATED set differently on the master and > > standby / after crash recovery. I'm failing to see any harmful > > consequences right now, but differences between master and standby are a bad > > thing. > > I think it's actually critical, because HEAP_HOT_UPDATED / > HEAP_XMAX_LOCK_ONLY are used to terminate ctid chasing loops (like > heap_hot_search_buffer()).
I've pushed a quite heavily revised version of the first patch to 9.1-master. I manually verified using pageinspect, gdb breakpoints and a standby that xmax, infomask etc are set correctly (leading to finding a4d357bf). As there's noticeable differences, especially 9.2->9.3, between versions, I'd welcome somebody having a look at the commits. Regards, Andres -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers