On 8/5/16 12:14 AM, Michael Paquier wrote: > In do_stop, this patches makes the wait happen for a maximum of > wait_seconds * 2, once when getting the control file information, and > once when waiting for the server to shut down.
That's not how I read it. get_controlfile() will decrease the wait_seconds argument by how much wait time it has used. The wait for shutdown will then only use as much seconds as are left. > This is not a good > idea, and the idea of putting a wait argument in get_controlfile does > not seem a good interface to me. I'd rather see get_controlfile be > extended with a flag saying no_error_on_failure and keep the wait > logic within pg_ctl. I guess we could write a wrapper function in pg_ctl that encapsulated the wait logic. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers