On Tue, Aug 9, 2016 at 5:34 PM, Julien Rouhaud <julien.rouh...@dalibo.com> wrote: > Since 14e8803f1, it's not necessary to acquire the SyncRepLock to see up > to date data. But it looks like this commit didn't update all the > comment around MyProc->syncRepState, which still mention retrieving the > value without and without lock. Also, there's I think a now unneeded > test to try to retrieve again syncRepState. > > Patch attached to fix both small issues, present since 9.5.
You could directly check MyProc->syncRepState and remove syncRepState. Could you add it to the next commit fest? I don't think this will get into 9.6 as this is an optimization. -- Michael -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers