On Thu, Aug 18, 2016 at 2:26 PM, Claudio Freire <klaussfre...@gmail.com> wrote: > I see that. I could try to measure average depth to measure the impact > this had on fan-in. > > While it should cut it in half for narrow indexes, half of very high > is still high. Wide indexes, which are are the ones that would suffer > from poor fan-in, would feel this far less, since the overhead is > constant.
You'll also have to consider the impact on the choice of split point, FWIW. There is currently leeway about what page an index tuple can land on, if and when it happens to be equal to the high-key. I'm not sure how important that is, but it's a consideration. > Even if it does have an impact, I don't see an alternative, without > also implementing suffix truncation. Perhaps I could try to avoid > adding the leaf tid header if it isn't necessary, though I would have > to use up the last available flag bit in t_info for that. To be clear, I'm particularly worried about painting ourselves into a corner, suffix-truncation-wise. It's a very common optimization, that we should really have. >> ISTM that the way to address this problem is with a duplicate list >> and/or prefix compression in leaf pages. > > Prefix compression is another one I will be looking into eventually, > but last time I tried it was far more invasive so I abandoned until I > could find a less invasive way to do it. Unfortunately, sometimes it is necessary to be very ambitious in order to solve a problem. The understandable and usually well-reasoned approach of making progress as incremental as possible occasionally works against contributors. It's worth considering if this is such a case. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers