On Wed, Mar 23, 2016 at 7:04 PM, Pavan Deolasee
> On Wed, Mar 23, 2016 at 1:13 PM, Michael Paquier <michael.paqu...@gmail.com>
>> + /*
>> + * Compute targetRecOff. It should typically be greater than short
>> + * page-header since a valid record can't , but can also be zero
>> + * caller has supplied a page-aligned address or when we are
>> + * multi-page continuation record. It doesn't matter though
>> + * ReadPageInternal() will read at least short page-header worth
>> + * data
>> + */
>> This needs some polishing, there is an unfinished sentence here.
>> + targetRecOff = tmpRecPtr % XLOG_BLCKSZ;
>> targetRecOff, pageHeaderSize and targetPagePtr could be declared
>> inside directly the new while loop.
> Thanks Michael for reviewing the patch. I've fixed these issues and new
> version is attached.
The patch looks good to me. Barring any objections,
I'll push this and back-patch to 9.3 where pg_xlogdump was added.
Sent via pgsql-hackers mailing list (email@example.com)
To make changes to your subscription: