On 2016-08-27 15:36:28 -0400, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > On 2016-08-27 14:08:44 -0400, Tom Lane wrote: > >> Barring objection, I propose to make these changes in HEAD and 9.6. > > > I think we might also / instead want to think about replacing a lot of > > those AllocSetContextCreate with a wrapper function. Currently is really > > rather annoying to experiment with switching the default allocator > > out. And if we're touching all that code anyway ... > > I do not see why you'd think that "switching the default allocator out" > requires anything except making AllocSetContextCreate do something else.
Well yea. But given it's explicitly tied to aset.c that doesn't seem like a sensible thing. DefaultContextCreate() or something (in mcxt.c), which then calls AllocSetContextCreate, seems better to me. > What is actually of interest, IMO, is making *some* contexts have a > different allocator, and that is going to require case-by-case decisions > anyway. A blanket switch seems completely useless to me. Don't think aset.c is actually that good, so I'm not convinced of that. And even if it's just to verify that a special case allocator actually works with more coverage... Andres -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers