On Mon, Aug 22, 2016 at 10:43 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Sat, Aug 6, 2016 at 6:35 PM, Andreas Seltenreich <seltenre...@gmx.de> > wrote: >> Michael Paquier writes: >> >>> Andreas, with the patch attached is the assertion still triggered? >>> [2. text/x-diff; base-backup-crash-v2.patch] >> >> I didn't observe the crashes since applying this patch. There should >> have been about five by the amount of fuzzing done. > > I have reworked the patch, replacing those two booleans with a single > enum. That's definitely clearer. Also, I have added this patch to the > CF to not lose track of it: > https://commitfest.postgresql.org/10/731/ > Horiguchi-san, I have added you as a reviewer as you provided some > input. I hope you don't mind.
You seem to add another entry for this patch into CommitFest. Either of them needs to be removed. https://commitfest.postgresql.org/10/698/ This patch prevents pg_stop_backup from starting while pg_start_backup is running. OTOH, we also should prevent pg_start_backup from starting until "previous" pg_stop_backup has completed? What happens if pg_start_backup starts while pg_stop_backup is running? As far as I read the current code, ISTM that there is no need to do that, but it's better to do the double check. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers