El 02/09/16 a las 04:19, Vik Fearing escribió: > >> 2. But I'm not sure that this will actually be useful to people. It >> seems like it might just be one more thing for patch authors to >> maintain. I think that if somebody wants to set a parameter defined >> for a contrib module, it's easy enough to just add an entry into >> postgresql.conf, or use ALTER SYSTEM .. SET. Going and finding the >> sample file (which only sets the value to the default) and then >> putting that into your postgresql.conf seems like an extra step. > > I was imagining just using the "include" directive. I have heard the > desire for annotated sample conf files for the contrib modules twice now > from different people which is why I wrote the patch. If we decide that > the extra documentation is too much of a burden, I can understand that, > also.
I think having a sample configuration file which we can include and make the specific configuration changes for that contrib has it's logic, and I believe it's a good idea to include. We suggest having a bdr.conf file separated with all the BDR configuration parameters, so this makes total sense. I will have a better check at the patch and get back (didn't find anything wrong at the first look at it). Regards, -- Martín Marqués http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
