On 4 September 2016 at 23:33, Tom Lane <t...@sss.pgh.pa.us> wrote:
> So my consciousness was raised just now by an example of exactly this
> scenario over in pgsql-novice. What I forgot was that the client may
> in fact be on the same machine as the server, in which case EACCES
> is pretty much exactly what you'd expect.
Yep. Also in cases with common paths, like /root or whatever.
> So we probably do want to
> hint for that case, but the hint wording I previously suggested no
> longer seems like le mot juste ... it needs to cover the idea that
> the client and server are different processes on the same machine.
Yeah, may be. *We* know that in this case "client" and "server" still
applies since client and server can be on the same host, but the
people who needs this hint may not understand that. Though there's
only so much we can do or should try to do in a HINT.
I think the most important bit is pointing them at \copy, so it's still useful.
To cover the same-host case we could try something like:
COPY runs on the PostgreSQL server, using the PostgreSQL server's
directories and permissions, it doesn't run on the client.
... but I think that's actually less helpful for the users who'll need this.
We could say "COPY runs as the PostgreSQL server" but that's the kind
of hint that mostly helps people who already understand it and don't
actually the hint.
(BTW, whoever came up with "EACCES" needs to go spend time with the
creat() system call somewhere dark and smelly).
> I don't suppose there's any easy way for COPY to distinguish local
> from remote connections
Not that I see, since "local" can be unix socket or tcp to localhost.
Not cleanly anyway.
I don't think it matters. Many hosts have enough paths in common that
in practice the hint on EACCES will be useful anyway. It'd be nice to
work in something about running with the permissions of the PostgreSQL
server, but I don't see a way to do that without making it all more
complex.
I don't think it's worth tons of time anyway. This will be better than
what we have, lets do it.
I'm fairly happy with the wording you came up with:
"COPY copies to a file on the PostgreSQL server, not on the client. "
"You may want a client-side facility such as psql's \\copy."
and am inclined to suggest going ahead with the existing wording. I
agree that removing the part for "relative path not allowed for COPY
to file" is reasonable, so I've attached an update that does so and
warns on EACCES too.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From a30266cdbf1febd033ad2ba127341e1da4677dae Mon Sep 17 00:00:00 2001
From: Craig Ringer <cr...@2ndquadrant.com>
Date: Fri, 12 Aug 2016 15:42:12 +0800
Subject: [PATCH] Emit a HINT when COPY can't find a file
Users often get confused between COPY and \copy and try to use client-side
paths with COPY. The server of course cannot find the file.
Emit a HINT in the most common cases to help users out.
Craig Ringer, review by Tom Lane and Christoph Berg
---
src/backend/commands/copy.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c
index 5947e72..341c058 100644
--- a/src/backend/commands/copy.c
+++ b/src/backend/commands/copy.c
@@ -1751,6 +1751,7 @@ BeginCopyTo(Relation rel,
{
mode_t oumask; /* Pre-existing umask value */
struct stat st;
+ int save_errno;
/*
* Prevent write to relative path ... too easy to shoot oneself in
@@ -1759,16 +1760,21 @@ BeginCopyTo(Relation rel,
if (!is_absolute_path(filename))
ereport(ERROR,
(errcode(ERRCODE_INVALID_NAME),
- errmsg("relative path not allowed for COPY to file")));
+ errmsg("relative path not allowed for COPY to file")));
oumask = umask(S_IWGRP | S_IWOTH);
cstate->copy_file = AllocateFile(cstate->filename, PG_BINARY_W);
+ save_errno = errno;
umask(oumask);
+
if (cstate->copy_file == NULL)
ereport(ERROR,
(errcode_for_file_access(),
errmsg("could not open file \"%s\" for writing: %m",
- cstate->filename)));
+ cstate->filename),
+ (save_errno == ENOENT || save_errno == EACCES ?
+ errhint("COPY copies to a file on the PostgreSQL server, not on the client. "
+ "You may want a client-side facility such as psql's \\copy.") : 0)));
if (fstat(fileno(cstate->copy_file), &st))
ereport(ERROR,
@@ -2786,13 +2792,21 @@ BeginCopyFrom(Relation rel,
else
{
struct stat st;
+ int save_errno;
cstate->copy_file = AllocateFile(cstate->filename, PG_BINARY_R);
+
+ /* in case something in ereport changes errno: */
+ save_errno = errno;
+
if (cstate->copy_file == NULL)
ereport(ERROR,
(errcode_for_file_access(),
errmsg("could not open file \"%s\" for reading: %m",
- cstate->filename)));
+ cstate->filename),
+ (save_errno == ENOENT || save_errno == EACCES ?
+ errhint("COPY copies from a file on the PostgreSQL server, not on the client. "
+ "You may want a client-side facility such as psql's \\copy.") : 0)));
if (fstat(fileno(cstate->copy_file), &st))
ereport(ERROR,
--
2.5.5
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
