Friends, there are several places in the code where variables defined as (char *) or as (const char *) are passed to the NameGetDatum() macro. I believe it would be better form to use CStringGetDatum() in these locations. I am aware that these two macros are internally the same.
src/backend/commands/proclang.c, line 466. src/backend/commands/dbcommands.c, lines 1263, 1489, 1606, 1746. Am I overlooking some reason why the code is correct as is? If not, I am attaching a patch that applies cleanly for me against master, compiles, and passes the regression tests. Thanks, Mark Dilger
NameGetDatum.patch.1
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
