On Wed, Sep 14, 2016 at 6:52 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 9/12/16 3:31 PM, Tom Lane wrote: >> Hm, there was just a kerfuffle about spelling things like this >> "--no-clean" etc. I wasn't on board with removing existing spellings, >> but surely all newly added switches should use the "no-" spelling? > > This is supposed to be parallel to initdb's option. So if we rename or > migrate the one in initdb, then we can just hard-rename this one. But > until that is decided, it seems better to keep it the same as initdb has > right now.
PostgresNode.pm had better use the new --noclean option in its calls, the new default is not useful for debugging. Please see attached. -- Michael
diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm index fede1e6..0b8c8e6 100644 --- a/src/test/perl/PostgresNode.pm +++ b/src/test/perl/PostgresNode.pm @@ -476,7 +476,7 @@ sub backup print "# Taking pg_basebackup $backup_name from node \"$name\"\n"; TestLib::system_or_bail('pg_basebackup', '-D', $backup_path, '-p', $port, - '-x'); + '-x', '--noclean'); print "# Backup finished\n"; }
-- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers