Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes: > I propose the attached patch to clean up some redundancy and confusion > in pg_dump.
Looks sane, though I'd suggest coding the access macros with shifts not multiplies/divides. Since these numbers are purely internal and not stored in this form in the file, I wonder whether we shouldn't drop the rightmost zero byte, ie make it just <maj><min><rev> not <maj><min><rev>00. That would save at least one divide/shift when accessing. regards, tom lane -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers