On Wed, Oct 26, 2016 at 6:19 AM, Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote: > Hello, compiler complains about unused variable during build > postgres_fdw without assertions (!--enable-cassert). > > deparse.c: In function ‘deparseFromExpr’: > deparse.c:1029:14: warning: unused variable ‘foreignrel’ [-Wunused-variable] > RelOptInfo *foreignrel = context->foreignrel; > ^~~~~~~~~~ > > The attched patch removes it and moves into the assertion below it. >
Thanks for the patch and sorry for missing this in the review. I The patch applies but seems to have a trailing white space. patch -p1 < /mnt/hgfs/tmp/postgre_fdw_delete_unused_var.patch (Stripping trailing CRs from patch.) patching file contrib/postgres_fdw/deparse.c But that's removed my "patch" command. It compiles cleanly and make check in contrib/postgres_fdw does not show any failure. -- Best Wishes, Ashutosh Bapat EnterpriseDB Corporation The Postgres Database Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers