> On 27 Oct 2016, at 09:23, Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> > wrote: > > Hello, thank you very much for the work. My work became quite > easier with it. > > At Tue, 25 Oct 2016 12:23:48 +0300, Heikki Linnakangas <hlinn...@iki.fi> > wrote in <08e7892a-d55c-eefe-76e6-7910bc8dd...@iki.fi> >> >> [..] >> The perl scripts are still quite messy. For example, I lost the checks >> for duplicate mappings somewhere along the way - that ought to be put >> back. My Perl skills are limited. > > Perl scripts are to be messy, I believe. Anyway the duplicate > check as been built into the sub print_radix_trees. Maybe the > same check is needed by some plain map files but it would be just > duplication for the maps having radix tree.
I took a small stab at doing some cleaning of the Perl scripts, mainly around using the more modern (well, modern as in +15 years old) form for open(..), avoiding global filehandles for passing scalar references and enforcing use strict. Some smaller typos and fixes were also included. It seems my Perl has become a bit rusty so I hope the changes make sense. The produced files are identical with these patches applied, they are merely doing cleaning as opposed to bugfixing. The attached patches are against the 0001-0006 patches from Heikki and you in this series of emails, the separation is intended to make them easier to read. cheers ./daniel
0007-Fix-filehandle-usage.patch
Description: Binary data
0008-Make-all-scripts-use-strict-and-rearrange-logic.patch
Description: Binary data
0009-Use-my-instead-of-local.patch
Description: Binary data
0010-Various-small-style-nits-and-typos.patch
Description: Binary data
0011-Fix-hash-lookup.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
