On Thu, Nov 3, 2016 at 5:23 PM, Dilip Kumar <dilipbal...@gmail.com> wrote:
> On Thu, Nov 3, 2016 at 9:57 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > Thanks for your suggestion. Yes, I agree that adding a hint is good. > > Updated patch is attached with addition of hint message. > > > > 2016-11-03 14:56:28.685 AEDT [7822] ERROR: cannot copy to view "ttt_v" > > 2016-11-03 14:56:28.685 AEDT [7822] HINT: To enable copy to view, > provide > > an INSTEAD OF INSERT trigger > > 2016-11-03 14:56:28.685 AEDT [7822] STATEMENT: COPY ttt_v FROM stdin; > > Okay, Patch in general looks fine to me. One cosmetic comments, IMHO > in PG we follow operator at end of the line, so move '&&' to end of > the previous line. > > + if (cstate->rel->rd_rel->relkind != RELKIND_RELATION > + && (!cstate->rel->trigdesc || > + !cstate->rel->trigdesc->trig_insert_instead_row)) > changed. > Meanwhile I will test it and give the feedback. Thanks. Updated patch is attached with added regression tests. Regards, Hari Babu Fujitsu Australia
copy_to_view_3.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
