On 7 November 2016 at 12:15, Jaime Casanova
<jaime.casan...@2ndquadrant.com> wrote:
> On 28 October 2016 at 02:53, Amit Langote <langote_amit...@lab.ntt.co.jp>
> wrote:
>>
>> Please find attached the latest version of the patches
>
> Hi,
>
> I started to review the functionality of this patch, so i applied all
> 9 patches. After that i found this warning, which i guess is because
> it needs a cast.
>
oh! i forgot the warning
"""
partition.c: In function ‘get_qual_for_list’:
partition.c:1159:6: warning: assignment from incompatible pointer type
or = makeBoolExpr(OR_EXPR, list_make2(nulltest2, opexpr), -1);
^
"""
attached a list of the warnings that my compiler give me (basically
most are just variables that could be used uninitialized)
--
Jaime Casanova www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
partition.c: In function ‘get_qual_for_list’:
partition.c:1159:6: warning: assignment from incompatible pointer type
or = makeBoolExpr(OR_EXPR, list_make2(nulltest2, opexpr), -1);
^
partition.c: In function ‘RelationBuildPartitionDesc’:
partition.c:250:8: warning: ‘num_distinct_bounds’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
int num_distinct_bounds;
^
partition.c:587:9: warning: ‘distinct_bounds’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
copy_range_bound(key, distinct_bounds[i]);
^
partition.c:536:5: warning: ‘all_values_count’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
for (i = 0; i < all_values_count; i++)
^
partition.c:243:23: warning: ‘all_values’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
PartitionListValue **all_values;
^
partition.c:619:35: warning: ‘oids’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
result->oids[mapping[i]] = oids[i];
^
partition.c: In function ‘get_qual_from_partbound’:
partition.c:973:10: warning: ‘my_qual’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
my_qual = (List *) map_variable_attnos((Node *) my_qual,
^
partition.c: In function ‘get_partition_for_tuple’:
partition.c:1734:8: warning: ‘index’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
if (node->index > index)
^
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
