Hi, On 2016-11-08 10:25:11 +0530, Amit Kapila wrote: > ifdef USE_PGXS > PG_CONFIG = pg_config > PGXS := $(shell $(PG_CONFIG) --pgxs) > @@ -21,3 +25,29 @@ top_builddir = ../.. > include $(top_builddir)/src/Makefile.global > include $(top_srcdir)/contrib/contrib-global.mk > endif > + > +# Disabled because these tests require > "shared_preload_libraries=pg_stat_statements", > +# which typical installcheck users do not have (e.g. buildfarm clients).
> +installcheck:; > + > +check: regresscheck > + > +submake-regress: > + $(MAKE) -C $(top_builddir)/src/test/regress all > + > +submake-pg_stat_statements: > + $(MAKE) -C $(top_builddir)/contrib/pg_stat_statements Why is this a submake? That seems to make little sense? But stepping back one step further: I don't think we need all the remade rules in the first place. REGRESS_OPTS = --temp-config $(top_srcdir)/contrib/pg_stat_statements/pg_stat_statements.conf and then installcheck: REGRESS= to prevent installcheck from doing anything ought to be enough these days. Committed after simplifying the Makefile. We can't simplify test_decoding's makefile to that extent, because it uses isolationtester, which we don't provide for contrib yet... Andres -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers