Hi Gilles,
On Sun, 30 Oct 2016 02:04:59 -0500
"Karl O. Pinc" <[email protected]> wrote:
> Attached is a patch to be applied on top of your v10 patch
> which does basic fixup to logfile_writename().
I'm looking at the v13 patch and don't see a change I submitted
with a patch to v10. You wrote:
snprintf(tempfn, sizeof(tempfn), "%s",
CURRENT_LOG_FILENAME);
strcat(tempfn, ".tmp");
I patched to:
snprintf(tempfn, sizeof(tempfn), "%s.tmp",
CURRENT_LOG_FILENAME);
As long as you're doing a snprintf() there's no point
in "risking" a buffer overflow by a subsequent strcat().
(Not that you're likely to ever get a buffer overflow.)
And why make two calls instead of 1? That's what's
in my head.
Regards,
Karl <[email protected]>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
