Daniel, * Daniel Verite (dan...@manitou-mail.org) wrote: > "make check" seems OK with that, I hope it doesn't cause any regression > elsewhere.
You can see what the code coverage of psql is in our current regression tests by going here: http://coverage.postgresql.org/src/bin/psql/index.html It's not exactly a pretty sight and certainly not all callers of ParseVariableBool() are covered. I'd strongly suggest you either do sufficient manual testing, or add regression tests, most likely using the tap test system (you can see an example of that in src/bin/pg_dump/t and in other 't' directories). You can generate that report after you make changes yourself using 'make coverage-html'. Thanks! Stephen
Description: Digital signature