> > [Summary]
> > 1. apply patch and make world
> >   -> failed because </para> was mistakenly coded <para>.
> >
> > 2.correct this mistake and make check-world
> >   -> got 1 failed test: "'pg_dumpall with \n\r in database name'"
> >      because test script cannot createdb "foo\n\rbar"
> The attached version addresses those problems. I have replaced the test in
> src/bin/pg_dump/t/ by tests in src/bin/scripts/t/ to check if the role name
> and database name with CR or LF fail to be created. I have as well added a 
> test
> for initdb when the data directory has an incorrect character in 0002.

Thanks for your modification.
I applied your fixed patch and new one, and confirmed the applied source passed 
the tests successfully. And I also checked manually the error messages were 
emitted successfully when cr/lf are included in dbname or rolename or 

AFAICT, this patch satisfies the concept discussed before. So I’ve switched 
this patch “Ready for Committer”.

Ideriha, Takeshi

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to