On Tue, Dec 6, 2016 at 2:13 PM, Michael Paquier
<michael.paqu...@gmail.com> wrote:
> On Tue, Dec 6, 2016 at 1:54 PM, Fujii Masao <masao.fu...@gmail.com> wrote:
>> + <literal>backup</>: The WAL sender is sending a backup.
>>
>> Seems it's better to use "This WAL sender" rather than "The WAL sender"
>> like the descriptions of other fields.
>>
>> There are two descriptions of "streaming" value. You need to remove
>> either of them.
>>
>> + <literal>streaming</>: The WAL sender is catching up with the
>> + primary.
>>
>> "walsender is catching up with the primary" sounds a bit strange to me.
>> What about "This WAL sender's connected standby server is catching up
>> with the primary"?
>>
>> + <literal>streaming</>: The WAL sender has caught up with the
>> + primary and is streaming changes.
>>
>> Same as above.
>
> Agreed with all that. Attached is an updated version.
Thanks for updating the patch! Attached is the updated version of the patch.
I changed the order of descriptions of the walsender state in
intuitive one rather than alphabetical one. Also I enhanced
the description of "potential" state.
Could you review the latest patch?
Regards,
--
Fujii Masao
*** a/doc/src/sgml/high-availability.sgml
--- b/doc/src/sgml/high-availability.sgml
***************
*** 1161,1166 **** synchronous_standby_names = '2 (s1, s2, s3)'
--- 1161,1170 ----
<literal>s2</> fails. <literal>s4</> is an asynchronous standby since
its name is not in the list.
</para>
+ <para>
+ The synchronous states of standby servers can be viewed using
+ the <structname>pg_stat_replication</structname> view.
+ </para>
</sect3>
<sect3 id="synchronous-replication-performance">
***************
*** 1235,1240 **** synchronous_standby_names = '2 (s1, s2, s3)'
--- 1239,1246 ----
will increase according to the length of time the standby has been down.
The standby is only able to become a synchronous standby
once it has reached <literal>streaming</> state.
+ This state can be viewed using
+ the <structname>pg_stat_replication</structname> view.
</para>
<para>
*** a/doc/src/sgml/monitoring.sgml
--- b/doc/src/sgml/monitoring.sgml
***************
*** 1357,1363 **** SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i
<row>
<entry><structfield>state</></entry>
<entry><type>text</></entry>
! <entry>Current WAL sender state</entry>
</row>
<row>
<entry><structfield>sent_location</></entry>
--- 1357,1389 ----
<row>
<entry><structfield>state</></entry>
<entry><type>text</></entry>
! <entry>Current WAL sender state.
! Possible values are:
! <itemizedlist>
! <listitem>
! <para>
! <literal>startup</>: This WAL sender is starting up.
! </para>
! </listitem>
! <listitem>
! <para>
! <literal>catchup</>: This WAL sender's connected standby is
! catching up with the primary.
! </para>
! </listitem>
! <listitem>
! <para>
! <literal>streaming</>: This WAL sender is streaming changes
! after its connected standby server has caught up with the primary.
! </para>
! </listitem>
! <listitem>
! <para>
! <literal>backup</>: This WAL sender is sending a backup.
! </para>
! </listitem>
! </itemizedlist>
! </entry>
</row>
<row>
<entry><structfield>sent_location</></entry>
***************
*** 1391,1397 **** SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i
<row>
<entry><structfield>sync_state</></entry>
<entry><type>text</></entry>
! <entry>Synchronous state of this standby server</entry>
</row>
</tbody>
</tgroup>
--- 1417,1444 ----
<row>
<entry><structfield>sync_state</></entry>
<entry><type>text</></entry>
! <entry>Synchronous state of this standby server.
! Possible values are:
! <itemizedlist>
! <listitem>
! <para>
! <literal>async</>: This standby server is asynchronous.
! </para>
! </listitem>
! <listitem>
! <para>
! <literal>potential</>: This standby server is now asynchronous,
! but can potentially become synchronous if one of current
! synchronous ones fails.
! </para>
! </listitem>
! <listitem>
! <para>
! <literal>sync</>: This standby server is synchronous.
! </para>
! </listitem>
! </itemizedlist>
! </entry>
</row>
</tbody>
</tgroup>
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
