On Wed, Dec 21, 2016 at 8:39 PM, Robert Haas <robertmh...@gmail.com> wrote:
> Committed the refactoring patch with some mild cosmetic adjustments.

> As to the second patch:
> +        if (jointype == JOIN_UNIQUE_INNER)
> +            jointype = JOIN_INNER;
> Isn't this dead code?  save_jointype might that value, but jointype won't.

Yes, it is.

I have fixed this, and also observed that comment for
try_partial_mergejoin_path header was having some problem, fixed that

> Apart from that and some cosmetic issues it looks basically OK to me
> on a first read-through.

Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Attachment: parallel_mergejoin_v3.patch
Description: Binary data

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to