On Wed, Dec 21, 2016 at 8:39 PM, Robert Haas <robertmh...@gmail.com> wrote: > Committed the refactoring patch with some mild cosmetic adjustments.
Thanks.. > > As to the second patch: > > + if (jointype == JOIN_UNIQUE_INNER) > + jointype = JOIN_INNER; > > Isn't this dead code? save_jointype might that value, but jointype won't. Yes, it is. I have fixed this, and also observed that comment for try_partial_mergejoin_path header was having some problem, fixed that too. > > Apart from that and some cosmetic issues it looks basically OK to me > on a first read-through. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
Description: Binary data
-- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers