> > I updated the patch a bit further: simplified the function name > (s/build_subquery_rel_tlists/build_subquery_tlists/), and revised comments a > little bit. Attached is an updated version > (postgres-fdw-subquery-support-v14.patch). And I rebased another patch for > PHVs against that patch, which is also attached > (postgres-fdw-phv-pushdown-v14.patch). > Few comments
In build_subquery_tlists(), why don't we handle base relations? + if (foreignrel->reloptkind != RELOPT_JOINREL) + return; Also, in this function, if fpinfo->tlist is already set, why do we want to build it again? In build_tlist_to_deparse(), if fpinfo->tlist for the given relation is set, we should just return it rather than constructing it again. -- Best Wishes, Ashutosh Bapat EnterpriseDB Corporation The Postgres Database Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
