Hi,

While working on pushing down more joins/updates to the remote, I noticed that in contrib/postgres_fdw/postgres_fdw.h the declaration of get_jointype_name is misplaced in the section of shippable.c. Since that function is defined in contrib/postgres_fdw/deparse.c, we should put that declaration in the section of deparse.c in the header file. Attached is a patch for that.


Best regards,
Etsuro Fujita
*** a/contrib/postgres_fdw/postgres_fdw.h
--- b/contrib/postgres_fdw/postgres_fdw.h
***************
*** 163,172 **** extern void deparseSelectStmtForRel(StringInfo buf, PlannerInfo *root,
  						RelOptInfo *foreignrel, List *tlist,
  						List *remote_conds, List *pathkeys,
  						List **retrieved_attrs, List **params_list);
  
  /* in shippable.c */
  extern bool is_builtin(Oid objectId);
  extern bool is_shippable(Oid objectId, Oid classId, PgFdwRelationInfo *fpinfo);
- extern const char *get_jointype_name(JoinType jointype);
  
  #endif   /* POSTGRES_FDW_H */
--- 163,172 ----
  						RelOptInfo *foreignrel, List *tlist,
  						List *remote_conds, List *pathkeys,
  						List **retrieved_attrs, List **params_list);
+ extern const char *get_jointype_name(JoinType jointype);
  
  /* in shippable.c */
  extern bool is_builtin(Oid objectId);
  extern bool is_shippable(Oid objectId, Oid classId, PgFdwRelationInfo *fpinfo);
  
  #endif   /* POSTGRES_FDW_H */
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to