On Fri, Jan 6, 2017 at 11:43 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > Few more comments: > 1. > no need to two extra lines, one is sufficient and matches the nearby > coding pattern.
-- Fixed. > 2. > Do you see anywhere else in the code the pattern of using @ symbol in > comments before function name? -- Fixed. > 3. > > after this change, i think you can directly use bucket in > _hash_finish_split instead of pageopaque->hasho_bucket -- Fixed. > 4. > > Won't the check similar to the existing check (if (*bufp == > so->hashso_bucket_buf || *bufp == so->hashso_split_bucket_buf)) just > above this code will suffice the need? If so, then you can check it > once and use it in both places. > -- Fixed. > 5. The reader and insertion algorithm needs to be updated in README. -- Added info in README. -- Thanks and Regards Mithun C Y EnterpriseDB: http://www.enterprisedb.com
Description: Binary data
-- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers