On Mon, Jan 16, 2017 at 10:00 PM, Magnus Hagander <mag...@hagander.net> wrote: > > > On Wed, Jan 4, 2017 at 3:32 PM, Peter Eisentraut > <peter.eisentr...@2ndquadrant.com> wrote: >> >> This patch looks reasonable to me. >> >> Attached is a top-up patch with a few small fixups. >> >> I suggest to wait for the resolution of the "Replication/backup >> defaults" thread. I would not want to be in a situation where users who >> have not been trained to use replication slots now have yet another >> restart-only parameter to set before they can take a backup. >> > > Thanks for the review and the top-up patch. I've applied it and pushed.
- if (replication_slot && includewal != STREAM_WAL) + if ((replication_slot || no_slot) && includewal != STREAM_WAL) Why do we need to check "no_slot" here? Since no_slot=true means that no temporary replication slot is specified, it's fine even with both -X none and fetch. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers