2017-01-16 19:43 GMT+01:00 Peter Geoghegan <p...@heroku.com>:
> On Mon, Jan 16, 2017 at 10:38 AM, Pavel Stehule <pavel.steh...@gmail.com>
> > Should not be enhanced regress tests too?
> We already have coverage of multi-pass external tuplesorts, as of a
> few months back. That didn't catch this bug only because it was a
> pass-by-value datum tuplesort. The relevant RELEASE_SLAB_SLOT() call
> does have line coverage already.
> I wouldn't object to adding a test case that would have exercised this
> bug, too. It took me a while to talk Tom into the test that was added
> several months back, which discouraged me from adding another test
> case here. (There were concerns about the overhead of an external sort
> test on slower buildfarm animals.)
> Peter Geoghegan