On 23 January 2017 at 01:11, Petr Jelinek <petr.jeli...@2ndquadrant.com> wrote: > On 20/01/17 22:30, Petr Jelinek wrote: >> Since it's not exactly straight forward to find when these need to be >> initialized based on commands, I decided to move the initialization code >> to exec_replication_command() since that's always called before anything >> so that makes it much less error prone (patch 0003). >> >> The 0003 should be backpatched all the way to 9.4 where multiple >> commands started using those buffers. >> > > Actually there is better place, the WalSndInit(). > > Just to make it easier for PeterE (or whichever committer picks this up) > I attached all the logical replication followup fix/polish patches: > > 0001 - Changes the libpqrcv_connect to use async libpq api so that it > won't get stuck forever in case of connect is stuck. This is preexisting > bug that also affects walreceiver but it's less visible there as there > is no SQL interface to initiate connection there. > > 0002 - Close replication connection when CREATE SUBSCRIPTION gets > canceled (otherwise walsender on the other side may stay in idle in > transaction state). > > 0003 - Fixes buffer initialization in walsender that I found when > testing the above two. This one should be back-patched to 9.4 since it's > broken since then. > > 0004 - Fixes the foreign key issue reported by Thom Brown and also adds > tests for FK and trigger handling.
This fixes the problem for me. Thanks. > > 0005 - Adds support for renaming publications and subscriptions. Works for me. I haven't tested the first 3. Regards Thom -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
