On Tue, Jan 24, 2017 at 2:14 PM, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > Some contrib functions fail to fail sooner when relations of unsupported > relkinds are passed, resulting in error message like one below: > > create table foo (a int); > create view foov as select * from foo; > select pg_visibility('foov', 0); > ERROR: could not open file "base/13123/16488": No such file or directory > > Attached patch fixes that for all such functions I could find in contrib. > > It also installs RELKIND_PARTITIONED_TABLE as unsupported in a couple of > places (in pageinspect and pgstattuple).
I have spent some time looking at your patch, and did not find any issues with it, nor did I notice code paths that were not treated or any other contrib modules sufferring from the same deficiencies that you may have missed. Nice work. -- Michael -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers