On Tue, Jan 31, 2017 at 12:55 PM, Haribabu Kommi
> On Tue, Jan 31, 2017 at 10:04 AM, Tom Lane <t...@sss.pgh.pa.us> wrote:
>> Haribabu Kommi <kommi.harib...@gmail.com> writes:
>> > On Mon, Jan 30, 2017 at 5:18 PM, Michael Paquier
>> > <michael.paqu...@gmail.com>
>> > wrote:
>> >> #define USER_AUTH_LAST uaPeer
>> >> StaticAssertStmt(lengthof(UserAuthName) == USER_AUTH_LAST + 1,
>> >> "UserAuthName must include all user authentication names");
>> > Thanks for the review. Added the static assert statement.
>> This isn't exactly bulletproof, since somebody could add another enum
>> value and forget to update the macro. Still, it's better than nothing.
>> I tried to make it a shade more idiot-proof by putting the #define
>> physically inside the enum list --- you'd have to really have blinders
>> on to not notice it there. (Not that people haven't made equally silly
>> mistakes :-(.)
>> Pushed with that adjustment. Thanks for working on this!
> Thanks for your support.
The modifications looks fine for me, thanks for adding the assertion.
Sent via pgsql-hackers mailing list (firstname.lastname@example.org)
To make changes to your subscription: