Hi, I have done some testing with the latest patch
1)./pgbench postgres -i -F 100 -s 20 2) update pgbench_accounts set filler = 'foo' where aid%10 = 0; 3) vacuum analyze pgbench_accounts; 4) set max_parallel_workers_per_gather = 4; 5) set max_parallel_workers = 4; *Machine Configuration :-* RAM :- 16GB VCPU :- 8 Disk :- 640 GB Test case script with out-file attached. *LCOV Report :- * File Names Line Coverage without Test cases Line Coverage with Test cases Function Coverage without Test cases Function Coverage with Test cases src/backend/executor/nodeGatherMerge.c 0.0 % 92.3 % 0.0 % 92.3 % src/backend/commands/explain.c 65.5 % 68.4 % 81.7 % 85.0 % src/backend/executor/execProcnode.c 92.50% 95.1 % 100% 100.0 % src/backend/nodes/copyfuncs.c 77.2 % 77.6 % 73.0 % 73.4 % src/backend/nodes/outfuncs.c 32.5 % 35.9 % 31.9 % 36.2 % src/backend/nodes/readfuncs.c 62.7 % 68.2 % 53.3 % 61.7 % src/backend/optimizer/path/allpaths.c 93.0 % 93.4 % 100 % 100% src/backend/optimizer/path/costsize.c 96.7 % 96.8 % 100% 100% src/backend/optimizer/plan/createplan.c 89.9 % 91.2 % 95.0 % 96.0 % src/backend/optimizer/plan/planner.c 95.1 % 95.2 % 97.3 % 97.3 % src/backend/optimizer/plan/setrefs.c 94.7 % 94.7 % 97.1 % 97.1 % src/backend/optimizer/plan/subselect.c 94.1 % 94.1% 100% 100% src/backend/optimizer/util/pathnode.c 95.6 % 96.1 % 100% 100% src/backend/utils/misc/guc.c 67.4 % 67.4 % 91.9 % 91.9 % On Wed, Feb 1, 2017 at 7:02 PM, Rushabh Lathia <rushabh.lat...@gmail.com> wrote: > Due to recent below commit, patch not getting apply cleanly on > master branch. > > commit d002f16c6ec38f76d1ee97367ba6af3000d441d0 > Author: Tom Lane <t...@sss.pgh.pa.us> > Date: Mon Jan 30 17:15:42 2017 -0500 > > Add a regression test script dedicated to exercising system views. > > Please find attached latest patch. > > > > On Wed, Feb 1, 2017 at 5:55 PM, Rushabh Lathia <rushabh.lat...@gmail.com> > wrote: > >> I am sorry for the delay, here is the latest re-based patch. >> >> my colleague Neha Sharma, reported one regression with the patch, where >> explain output for the Sort node under GatherMerge was always showing >> cost as zero: >> >> explain analyze select '' AS "xxx" from pgbench_accounts where filler >> like '%foo%' order by aid; >> QUERY >> PLAN >> ------------------------------------------------------------ >> ------------------------------------------------------------ >> ------------------------ >> Gather Merge (cost=47169.81..70839.91 rows=197688 width=36) (actual >> time=406.297..653.572 rows=200000 loops=1) >> Workers Planned: 4 >> Workers Launched: 4 >> -> Sort (*cost=0.00..0.00 rows=0 width=0*) (actual >> time=368.945..391.124 rows=40000 loops=5) >> Sort Key: aid >> Sort Method: quicksort Memory: 3423kB >> -> Parallel Seq Scan on pgbench_accounts (cost=0.00..42316.60 >> rows=49422 width=36) (actual time=296.612..338.873 rows=40000 loops=5) >> Filter: (filler ~~ '%foo%'::text) >> Rows Removed by Filter: 360000 >> Planning time: 0.184 ms >> Execution time: 734.963 ms >> >> This patch also fix that issue. >> >> >> >> >> On Wed, Feb 1, 2017 at 11:27 AM, Michael Paquier < >> michael.paqu...@gmail.com> wrote: >> >>> On Mon, Jan 23, 2017 at 6:51 PM, Kuntal Ghosh >>> <kuntalghosh.2...@gmail.com> wrote: >>> > On Wed, Jan 18, 2017 at 11:31 AM, Rushabh Lathia >>> > <rushabh.lat...@gmail.com> wrote: >>> >> >>> > The patch needs a rebase after the commit 69f4b9c85f168ae006929eec4. >>> >>> Is an update going to be provided? I have moved this patch to next CF >>> with "waiting on author" as status. >>> -- >>> Michael >>> >> >> >> >> -- >> Rushabh Lathia >> > > > > -- > Rushabh Lathia > > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers > > -- Regards, Neha Sharma
\! pgbench -F 100 -i -s 20 regression \set VERBOSITY verbose update pgbench_accounts set filler = 'foo' where aid%10 = 0; vacuum analyze pgbench_accounts; set max_parallel_workers_per_gather = 4; set max_parallel_workers = 4; explain analyse select count(b.aid) from pgbench_accounts CROSS JOIN pgbench_accounts as a CROSS JOIN pgbench_accounts as b where a.filler like '%foo%'group by a.aid,b.abalance; explain analyze select sum(aid) from pgbench_accounts where aid % 25= 0 group by aid; --this created a crash which was fixed by dev later explain analyze select '' AS "xxx" from pgbench_accounts where filler like '%foo%' group by aid; --performance improved about 65% explain analyze select distinct(aid) from pgbench_accounts where filler like '%foo%' group by aid; --performance improved about 70% explain analyze select distinct(bid) from pgbench_accounts where filler like '%foo%' group by aid; --performance improved about 60% explain analyze select avg(a.aid) from pgbench_accounts a join pgbench_accounts b using (aid) where a.filler like '%foo%' group by aid; --performance improved about 60% explain analyse select distinct(aid) from pgbench_accounts where filler in ( select filler from pgbench_accounts where filler like '%foo%') and aid % 25 =0 group by aid; explain analyze select count(aid) from pgbench_accounts where bid = aid group by bid; explain analyze select max(abalance) from pgbench_accounts where bid % aid >= aid % bid and aid % 10 = 0 group by bid; explain analyze select max(bid) from pgbench_accounts where filler like '%foo%' and bid % 10 = 0 group by aid having bid % 10 = 0; explain analyze select max(bid),min(aid) from pgbench_accounts where aid % 10 = 0 group by bid; explain analyze select max(bid) from pgbench_accounts where bid <= aid and aid % 10 = 0 group by (aid,bid); explain analyse select sum(a.bid),min(b.aid) from pgbench_accounts a,pgbench_accounts b where a.aid % 10 = b.aid % 25 group by a.aid; explain analyze select distinct(a.aid) from pgbench_accounts a join pgbench_accounts b using (aid) where a.filler like '%foo%' and b.aid % 25 = 0 group by aid; --This case is under discussion with Developer,why sort node cost is '0' explain analyze select '' AS "xxx" from pgbench_accounts where filler like '%foo%' order by aid;
gather_merge_functional_test_cases.out
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
