On 02/24/2017 02:55 PM, Andrew Dunstan wrote: > > On 02/24/2017 11:02 AM, Tom Lane wrote: >>> I don't know what to call it either. In my test I used >>> CallerContextFunctionCall2 - not sure if that's quite right, but should >>> be close. >> CallerInfo? CallerFInfo? Or we could spell out CallerFmgrInfo but >> that seems a bit verbose. >> >> > I'll go with CallerFInfoFunctionCall2 etc. > > In the btree_gist system the calls to the routines like enum_cmp are > buried about three levels deep. I'm thinking I'll just pass the flinfo > down the stack and just call these routines at the bottom level. > > >
It's occurred to me that we could reduce the code clutter in fmgr.c a bit by turning the DirectFunctionCall{n]Coll functions into macros calling these functions and passing NULL as the flinfo param. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers