On 2017-02-28 23:15:15 -0800, Andres Freund wrote: > On 2016-12-08 13:34:41 -0800, Andres Freund wrote: > > Hi, > > > > I'm wondering if it's not time for $subject: > > - V0 causes confusion / weird crashes when PG_FUNCTION_INFO_V1 was > > forgotten > > - They have us keep weird hacks around just for the sake of testing V0 > > - they actually cost performance, because we have to zero initialize > > Datums, even if > > the corresponding isnull marker is set. > > - they allow to call arbitrary functions pretty easily > > > > I don't see any reason to keep them around. If seriously doubt anybody > > is using them seriously in anything but error. > > Patches attached.
One unaddressed question in those patches is what we do with src/backend/utils/fmgr/README - I'm not quite sure what its purpose is, in its current state. If we want to keep it, we'd probably have to pretty aggressively revise it? - Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
