On 3/3/17 09:03, Tomas Vondra wrote: > Damn. In my defense, the patch was originally created for an older > PostgreSQL version (to investigate issue on a production system), which > used that approach to building values. Should have notice it, though. > > Attached is v2, fixing both issues.
Can we have a test case for page_checksum(), or is that too difficult to get running deterministicly? Also, perhaps page_checksum() doesn't need to be superuser-only, but I can see arguments for keeping it that way for consistency. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers