Amit Langote <langote_amit...@lab.ntt.co.jp> writes: > Also, I found out that alter_table.sql mistakenly forgot to drop > partitioned table "p1". Patch 0002 takes care of that.
While that might or might not have been intentional, I think it's an astoundingly bad idea to not leave any partitioned tables behind in the final state of the regression database. Doing so would likely have meant that this particular bug evaded detection for much longer than it did. Moreover, it would mean that the pg_upgrade test would have exactly no coverage of partitioned cases. Therefore, there should definitely be a partitioned table, hopefully with a less generic name than "p1", in the final regression DB state. Whether this particular one from alter_table.sql is a good candidate, I dunno. But let's not drop it without adding a better-thought-out replacement. regards, tom lane -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers