Hi, On 2017-03-09 19:04:46 -0800, Peter Geoghegan wrote: > On Thu, Mar 9, 2017 at 4:41 PM, Andres Freund <and...@anarazel.de> wrote: > > I don't really expect buildfarm fallout, but .. > > Unfortunately, there is some on Windows:
Thanks for monitoring. > verify_nbtree.obj : error LNK2001: unresolved external symbol > RecentGlobalXmin > [C:\buildfarm\buildenv\HEAD\pgsql.build\amcheck.vcxproj] > > Rather than marking RecentGlobalXmin as PGDLLIMPORT, I'd rather just > remove the documenting assertion and leave that comment as-is. I'll > work on a patch for this soon. Hm - I think it's fair to export RecentGlobalXmin, given that we obviously use it across modules in core code. I see very little reason not to export it. Greetings, Andres Freund -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers