On Fri, Mar 17, 2017 at 12:30 PM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > On Fri, Mar 17, 2017 at 9:03 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: >> On Thu, Mar 16, 2017 at 1:15 PM, Ashutosh Sharma <ashu.coe...@gmail.com> >> wrote: >>> Hi, >>> >>> Attached is the patch that allows WAL consistency tool to mask >>> 'LH_PAGE_HAS_DEAD_TUPLES' flag in hash index. The flag got added as a >>> part of 'Microvacuum support for Hash index' patch . I have already >>> tested it using Kuntal's WAL consistency tool and it works fine. >>> >> >> + * unlogged. So, mask it. See _hash_kill_items(), MarkBufferDirtyHint() >> + * for >> details. >> + */ >> >> I think in above comment, a reference to _hash_kill_items is >> sufficient. Other than that patch looks okay. > > Okay, I have removed the reference to MarkBufferDirtyHint() from above > comment. Attached is the v2 version of patch. >
Thanks, this version looks good to me. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
