On Tue, Mar 21, 2017 at 7:18 PM, Peter Geoghegan <p...@bowt.ie> wrote: >> As shown in 0008-hj-shared-buf-file-v8.patch. Thoughts? > > A less serious issue I've also noticed is that you add palloc() calls, > implicitly using the current memory context, within buffile.c. > BufFileOpenTagged() has some, for example. However, there is a note > that we don't need to save the memory context when we open a BufFile > because we always repalloc(). That is no longer the case here.
Similarly, I think that your new type of BufFile has no need to save CurrentResourceOwner, because it won't ever actually be used. I suppose that you should at least note this in comments. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers