I found a grammatical error in one of the code comments. The comment is made regarding the run-time of the algorithm, and references big-O performance. However the comment text uses "effective", instead of the probably more correct "efficient".
The original comment reads as though the code would not do its job correctly, rather than just not very quickly. Regards Emil
--- src/backend/commands/publicationcmds.c.orig 2017-03-22 14:24:10.838593000 +0100 +++ src/backend/commands/publicationcmds.c 2017-03-22 14:25:14.410045000 +0100 @@ -525,7 +525,7 @@ myrelid = RelationGetRelid(rel); /* * filter out duplicates when user specifies "foo, foo" - * Note that this algorithm is know to not be very effective (O(N^2)) + * Note that this algorithm is known to not be very efficient (O(N^2)) * but given that it only works on list of tables given to us by user * it's deemed acceptable. */
-- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers