On Thu, Mar 23, 2017 at 10:50 PM, Simon Riggs <si...@2ndquadrant.com> wrote: >> Second thoughts... I'll just make LagTrackerWrite externally >> available, so a plugin can send anything it wants to the tracker. >> Which means I'm explicitly removing the "logical replication support" >> from this patch. > > Done. > > Here's the patch I'm looking to commit, with some docs and minor code > changes as discussed.
Thank you for committing this. Time-based replication lag tracking seems to be a regular topic on mailing lists and IRC, so I hope that this will provide what people are looking for and not simply replace that discussion with a new discussion about what lag really means :-) Many thanks to Simon and Fujii-san for convincing me to move the buffer to the sender (which now seems so obviously better), to Fujii-san for the idea of tracking write and flush lag too, and to Abhijit, Sawada-san, Ian, Craig and Robert for valuable feedback. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers