On Fri, Mar 24, 2017 at 8:36 PM, Heikki Linnakangas <hlinn...@iki.fi> wrote: > On 03/23/2017 06:41 AM, Michael Paquier wrote: >> >> And after a lookup the failure is here: >> - result = get_role_password(port->user_name, &shadow_pass, logdetail); >> + shadow_pass = get_role_password(port->user_name, logdetail); >> if (result == STATUS_OK) >> result is never setup in this code path, so that may crash. > > Ah, of course. For some reason, I has -Wno-maybe-uninitialized in my > configure command line. Without that, gcc even warns about that. > > Fixed, and pushed. Thanks!
OK, cool. In order to close this thread, I propose to reuse the patches I sent here to make scram_build_verifier() available to frontends: https://www.postgresql.org/message-id/CAB7nPqT4yc3u8wspYkWbG088Ndp6asMH3=zb___ck89ctvz...@mail.gmail.com And on top of it modify \password so as it generates a md5 verifier for pre-9.6 servers and a scram one for post-10 servers by looking at the backend version of the current connection. What do you think? -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
