Hi, Seems pg_get_statisticsextdef() has a couple of things wrong:
1. HeapTupleIsValid() called on the wrong tuple. 2. Did not schema qualify names. Both of which were my mistakes. The attached fixes. I've also added some tests to give the function a bit of coverage. I've purposefully left out the WITH syntax. We'll want to add some logic around that once we have more than one statistic type supported. I'd suggest not appending WITH if all supported types are present, and only appending it if a true subset are present. That'll mean pg_dump from v10 and import into v11 will get all types, if they did in v10, and the same subset that they did in v10 when only a subset were originally defined. Since we support only 1 type now, nothing needs to happen there yet. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
pg_get_statisticsextdef_fix.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
