On Tue, Mar 21, 2017 at 10:11 AM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > Hi, > > While working on - [1], I realised that the following comments in > _hash_alloc_buckets() needs to be corrected. > > /* > * Initialize the freed overflow page. Just zeroing the page won't work, > * See _hash_freeovflpage for similar usage. > */ > _hash_pageinit(page, BLCKSZ); > > Attached is the patch that corrects above comment. Thanks. >
- * Initialize the freed overflow page. Just zeroing the page won't work, + * Initialize the last page in hash index. I think saying ".. last page in hash index" sounds slightly awkward as this is the last page for current split point, how about just "Initialize the page. ..." -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
