Please ignore reports about errors in other tests. Seem spurious.. Regards, Nikhils
On 28 March 2017 at 10:40, Nikhil Sontakke <nikh...@2ndquadrant.com> wrote: > Hi Micheal, > > The latest patch looks good. By now doing a single scan of shmem two phase > data, we have removed the double loops in all the affected functions which > is good. > > My only question is if the added call to restoreTwoPhaseData() is good > enough to handle all the 3 functions PrescanPreparedTransactions(), > StandbyRecoverPreparedTransactions() and RecoverPreparedTransactions() > appropriately? It looks as if it does, but we need to be doubly sure.. > > PFA, revised patch with a very minor typo fix and rebase against latest > master. The test cases pass as needed. > > Oh, btw, while running TAP tests, I got a few errors in unrelated tests. > > "# testing connection parameter "target_session_attrs" > > not ok 5 - connect to node master if mode "read-write" and > master,standby_1 listed > > > # Failed test 'connect to node master if mode "read-write" and > master,standby_1 listed' > > # at t/001_stream_rep.pl line 93. > > # got: '' > > # expected: '1' > > not ok 6 - connect to node master if mode "read-write" and > standby_1,master listed > > > # Failed test 'connect to node master if mode "read-write" and > standby_1,master listed' > > # at t/001_stream_rep.pl line 93. > > # got: '' > > # expected: '1' > > not ok 7 - connect to node master if mode "any" and master,standby_1 listed > > > # Failed test 'connect to node master if mode "any" and master,standby_1 > listed' > > # at t/001_stream_rep.pl line 93. > > # got: '' > > # expected: '1' > > not ok 8 - connect to node standby_1 if mode "any" and standby_1,master > listed" > > Again, not related to this recovery code path, but not sure if others see > this as well. > > Regards, > Nikhils > > On 27 March 2017 at 05:35, Michael Paquier <michael.paqu...@gmail.com> > wrote: > >> On Sun, Mar 26, 2017 at 4:50 PM, Nikhil Sontakke >> <nikh...@2ndquadrant.com> wrote: >> > I was away for a bit. I will take a look at this patch and get back to >> you >> > soon. >> >> No problem. Thanks for your time! >> -- >> Michael >> > > > > -- > Nikhil Sontakke http://www.2ndQuadrant.com/ > PostgreSQL/Postgres-XL Development, 24x7 Support, Training & Services > -- Nikhil Sontakke http://www.2ndQuadrant.com/ PostgreSQL/Postgres-XL Development, 24x7 Support, Training & Services
