On 4/14/17 12:09, Petr Jelinek wrote: > Indeed, if catchup phase didn't happen (because tablesync was faster > than apply) then the commit handler is never called so all the changes > made by copy would be forgotten. Also the tablesync worker might exit > from process_syncing_tables() call which is called before we report > stats in the commit handler so again some changes might be forgotten. > > I attached modified version of the patch that also reports stats in > finish_sync_worker() when there is outstanding transaction. The test can > stay the same.
committed (without the tests) -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers