On 18 April 2017 at 09:51, Simon Riggs <si...@2ndquadrant.com> wrote: > On 17 April 2017 at 16:33, Jeff Janes <jeff.ja...@gmail.com> wrote: >> On Sun, Apr 16, 2017 at 6:59 PM, Michael Paquier <michael.paqu...@gmail.com> >> wrote: >>> >>> >>> >>> Jeff, does this patch make the situation better? The fix is rather >>> simple as it just makes sure that the next XID never gets updated if >>> there are no 2PC files. >> >> >> Yes, that fixes the reported case when 2PC are not being used. > > Thanks Jeff. > > I certainly prefer the simplicity of Michael's approach. I'll move to commit.
Minor change to patch. I've added a recheck in ProcessTwoPhaseBuffer() after we acquire the lock. If its worth acquiring the lock its worth checking we don't have a race. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Description: Binary data
-- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers