On Thu, Apr 27, 2017 at 12:51 AM, Fujii Masao <[email protected]> wrote: > On Wed, Apr 26, 2017 at 4:03 PM, Kyotaro HORIGUCHI > <[email protected]> wrote: >> At Tue, 25 Apr 2017 14:45:03 -0400, Peter Eisentraut >> <[email protected]> wrote in >> <[email protected]> >>> On 4/6/17 08:24, Kyotaro HORIGUCHI wrote: >>> > The attached patch wakes up launcher when a subscription is >>> > enabled. This fails when a subscription is enabled immedaitely >>> > after disabling but it won't be a matter. >>> >>> committed, thanks >> >> Thanks! > > This patch makes me think that CREATE SUBSCRIPTION should also wake up > the launcher only when ENABLE is specified. Patch attached. Thought? >
That makes sense to me. Since NOCONNECT option changes some default values including ENABLED to false I think we should apply it also when NOCONNECT is specified? Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
