On 2017/05/16 10:03, Thomas Munro wrote: > On Tue, May 16, 2017 at 12:32 PM, Amit Langote > <langote_amit...@lab.ntt.co.jp> wrote: >> I vote for ExecCleanupTriggerState(estate). After your patch, there will >> be 4 places, including afterTriggerInvokeEvents(), ExecEndPlan(), and >> EvalPlanQualEnd(), that repeat the same block of code. > > Ok, here's a patch like that.
Thanks, looks good to me. > The call to ExecCloseIndices() may > technically be redundant (we never opened them). Actually yes. We never do ExecOpenIndices() on the ResultRelInfos contained in es_trig_target_relations. Thanks, Amit -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers