The patch looks ok,


but the main issue is missing regress tests.

Yes, I agree.

I know so it is another patch. But it should be placed differently

1. first patch - initial infrastructure for pgbench regress tests
2. this patch + related regress tests

Yep. I have no control about the display order, committers are too few and overbooked, pgbench is not necessarily a priority, so I can only wait for the non-regression test improvements to get committed some day before updating/adding tests for the other patches in the queue (query result in variable, utf8 variable names...).


Sent via pgsql-hackers mailing list (
To make changes to your subscription:

Reply via email to