On Sun, Jun 4, 2017 at 12:43:17AM +0900, Dang Minh Huong wrote:
On May 30, 29 Heisei, at 00:22, Dang Minh Huong <kakalo...@gmail.com> wrote:
On May 29, 29 Heisei, at 10:47, Thomas Munro <thomas.mu...@enterprisedb.com <mailto:thomas.mu...@enterprisedb.com>> wrote:
On Sun, May 28, 2017 at 7:55 PM, Dang Minh Huong <kakalo...@gmail.com <mailto:kakalo...@gmail.com>> wrote:
Thanks for reporting and lecture about unicode.
I attached a patch as the instruction from Thomas. Could you confirm it.
- is_plain_letter(table[codepoint.combining_ids]) and \
+ (is_plain_letter(table[codepoint.combining_ids]) or\
+ len(table[codepoint.combining_ids].combining_ids) > 1) and \
Shouldn't you use "or is_letter_with_marks()", instead of "or len(...)
1"? Your test might catch something that isn't based on a 'letter'(according to is_plain_letter). Otherwise this looks pretty good to
me. Please add it to the next commitfest.
Thanks for confirm, sir.
I will add it to the next CF soon.
Sorry for lately response. I attach the update patch.
Uh, there is no patch attached.
Sorry sir, reattach the patch.
I also added it to the next CF and set reviewers to Thomas Munro. Could you confirm for me.
Description: Binary data
Thanks and best regards,
Dang Minh Huong